diff options
| author | Namhyung Kim <namhyung@kernel.org> | 2025-11-06 11:00:23 -0800 |
|---|---|---|
| committer | Namhyung Kim <namhyung@kernel.org> | 2025-11-06 17:29:16 -0800 |
| commit | 6bd89ae7d14788ba15e25289479addcb98e7dc26 (patch) | |
| tree | ffbf7d3cba38ab6825789b4cf718aae4744335cd /tools/perf/util/header.c | |
| parent | 4df43709370cc18e9b09aa8049a6ab1f780af77e (diff) | |
| download | lwn-6bd89ae7d14788ba15e25289479addcb98e7dc26.tar.gz lwn-6bd89ae7d14788ba15e25289479addcb98e7dc26.zip | |
perf record: Make sure to update build-ID cache
Recent change on enabling --buildid-mmap by default brought an issue
with build-id handling. With build-ID in MMAP2 records, we don't need
to save the build-ID table in the header of a perf data file.
But the actual file contents still need to be cached in the debug
directory for annotation etc. Split the build-ID header processing and
caching and make sure perf record to save hit DSOs in the build-ID cache
by moving perf_session__cache_build_ids() to the end of the record__
finish_output().
Reviewed-by: Ian Rogers <irogers@google.com>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Diffstat (limited to 'tools/perf/util/header.c')
| -rw-r--r-- | tools/perf/util/header.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c index 4f2a6e10ed5c..4de7ca16b552 100644 --- a/tools/perf/util/header.c +++ b/tools/perf/util/header.c @@ -335,7 +335,6 @@ static int write_build_id(struct feat_fd *ff, pr_debug("failed to write buildid table\n"); return err; } - perf_session__cache_build_ids(session); return 0; } |