diff options
| author | Roel Kluin <roel.kluin@gmail.com> | 2009-10-23 16:03:08 +0200 |
|---|---|---|
| committer | Takashi Iwai <tiwai@suse.de> | 2009-10-30 12:25:07 +0100 |
| commit | 84ed1a1942e8c28fb4c23a6235ec48672fc43e49 (patch) | |
| tree | 67b0d7a9c639cddd9cb6319ed67e0c0d6a680dd7 /sound/pci/emu10k1/io.c | |
| parent | a688e4885c1aa6b88ab5ffa64655bacc01749c9e (diff) | |
| download | lwn-84ed1a1942e8c28fb4c23a6235ec48672fc43e49.tar.gz lwn-84ed1a1942e8c28fb4c23a6235ec48672fc43e49.zip | |
ALSA: Cleanup redundant tests on unsigned
The variables are unsigned so the test `>= 0' is always true,
the `< 0' test always fails. In these cases the other part of
the test catches wrapped values.
In dac_audio_write() there does not occur a test for wrapped
values, but the test appears redundant.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/pci/emu10k1/io.c')
| -rw-r--r-- | sound/pci/emu10k1/io.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/pci/emu10k1/io.c b/sound/pci/emu10k1/io.c index c1a5aa15af8f..5ef7080e14d0 100644 --- a/sound/pci/emu10k1/io.c +++ b/sound/pci/emu10k1/io.c @@ -256,7 +256,7 @@ int snd_emu1010_fpga_write(struct snd_emu10k1 * emu, u32 reg, u32 value) if (reg > 0x3f) return 1; reg += 0x40; /* 0x40 upwards are registers. */ - if (value < 0 || value > 0x3f) /* 0 to 0x3f are values */ + if (value > 0x3f) /* 0 to 0x3f are values */ return 1; spin_lock_irqsave(&emu->emu_lock, flags); outl(reg, emu->port + A_IOCFG); |