diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2011-09-29 09:10:48 +0300 |
|---|---|---|
| committer | Takashi Iwai <tiwai@suse.de> | 2011-09-29 08:12:33 +0200 |
| commit | bb690c9e2702e49af3be2fb6f03d9b60e0afcab7 (patch) | |
| tree | a63ec12c6a3fcfa166a8d93998022a8849413d7f /sound/oss | |
| parent | 17d900c4a1b50bc191b3ca58cbd78acc04a1c5b3 (diff) | |
| download | lwn-bb690c9e2702e49af3be2fb6f03d9b60e0afcab7.tar.gz lwn-bb690c9e2702e49af3be2fb6f03d9b60e0afcab7.zip | |
sound: oss: use strlcpy() in sound_timer_init()
sound_timer.info.name is a 32 character buffer. This function only
has one caller (in sound/oss/ad1848.c) and it passes as 128 character
buffer as "name". I don't know if this is a problem in real life,
and I doubt we're going to add more OSS drivers so it's unlikely to
become an issue. But we may as well take care of it.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/oss')
| -rw-r--r-- | sound/oss/sound_timer.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/oss/sound_timer.c b/sound/oss/sound_timer.c index 48cda6c4c257..8021c85f076d 100644 --- a/sound/oss/sound_timer.c +++ b/sound/oss/sound_timer.c @@ -320,7 +320,7 @@ void sound_timer_init(struct sound_lowlev_timer *t, char *name) n = sound_alloc_timerdev(); if (n == -1) n = 0; /* Overwrite the system timer */ - strcpy(sound_timer.info.name, name); + strlcpy(sound_timer.info.name, name, sizeof(sound_timer.info.name)); sound_timer_devs[n] = &sound_timer; } EXPORT_SYMBOL(sound_timer_init); |