summaryrefslogtreecommitdiff
path: root/sound/core/Kconfig
diff options
context:
space:
mode:
authorTakashi Iwai <tiwai@suse.de>2018-03-23 08:03:26 +0100
committerTakashi Iwai <tiwai@suse.de>2018-03-23 22:18:05 +0100
commit40cab6e88cb0b6c56d3f30b7491a20e803f948f6 (patch)
tree229da33d93b78fe63bab43877449301d32855af2 /sound/core/Kconfig
parent02a5d6925cd34c3b774bdb8eefb057c40a30e870 (diff)
downloadlwn-40cab6e88cb0b6c56d3f30b7491a20e803f948f6.tar.gz
lwn-40cab6e88cb0b6c56d3f30b7491a20e803f948f6.zip
ALSA: pcm: Return -EBUSY for OSS ioctls changing busy streams
OSS PCM stream management isn't modal but it allows ioctls issued at any time for changing the parameters. In the previous hardening patch ("ALSA: pcm: Avoid potential races between OSS ioctls and read/write"), we covered these races and prevent the corruption by protecting the concurrent accesses via params_lock mutex. However, this means that some ioctls that try to change the stream parameter (e.g. channels or format) would be blocked until the read/write finishes, and it may take really long. Basically changing the parameter while reading/writing is an invalid operation, hence it's even more user-friendly from the API POV if it returns -EBUSY in such a situation. This patch adds such checks in the relevant ioctls with the addition of read/write access refcount. Cc: <stable@vger.kernel.org> Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/core/Kconfig')
0 files changed, 0 insertions, 0 deletions