diff options
| author | David Howells <dhowells@redhat.com> | 2015-09-25 16:30:08 +0100 |
|---|---|---|
| committer | Jiri Slaby <jslaby@suse.cz> | 2015-11-18 10:27:20 +0100 |
| commit | f4562591c143cc272eab0d95be01dcca528627b9 (patch) | |
| tree | 570f98022d04eef598aa05abdd9bdc198fc826f3 /security/keys | |
| parent | 9df1a69674639ed58d04437f8b66942ca0ef72cc (diff) | |
| download | lwn-f4562591c143cc272eab0d95be01dcca528627b9.tar.gz lwn-f4562591c143cc272eab0d95be01dcca528627b9.zip | |
KEYS: Fix race between key destruction and finding a keyring by name
commit 94c4554ba07adbdde396748ee7ae01e86cf2d8d7 upstream.
There appears to be a race between:
(1) key_gc_unused_keys() which frees key->security and then calls
keyring_destroy() to unlink the name from the name list
(2) find_keyring_by_name() which calls key_permission(), thus accessing
key->security, on a key before checking to see whether the key usage is 0
(ie. the key is dead and might be cleaned up).
Fix this by calling ->destroy() before cleaning up the core key data -
including key->security.
Reported-by: Petr Matousek <pmatouse@redhat.com>
Signed-off-by: David Howells <dhowells@redhat.com>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Diffstat (limited to 'security/keys')
| -rw-r--r-- | security/keys/gc.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/security/keys/gc.c b/security/keys/gc.c index 797818695c87..483ebdf9c383 100644 --- a/security/keys/gc.c +++ b/security/keys/gc.c @@ -187,6 +187,10 @@ static noinline void key_gc_unused_keys(struct list_head *keys) kdebug("- %u", key->serial); key_check(key); + /* Throw away the key data */ + if (key->type->destroy) + key->type->destroy(key); + security_key_free(key); /* deal with the user's key tracking and quota */ @@ -201,10 +205,6 @@ static noinline void key_gc_unused_keys(struct list_head *keys) if (test_bit(KEY_FLAG_INSTANTIATED, &key->flags)) atomic_dec(&key->user->nikeys); - /* now throw away the key memory */ - if (key->type->destroy) - key->type->destroy(key); - key_user_put(key->user); kfree(key->description); |