diff options
author | Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> | 2022-04-21 11:25:05 -0500 |
---|---|---|
committer | Mark Brown <broonie@kernel.org> | 2022-04-23 00:16:28 +0100 |
commit | 8ad0b83e0079564989ccbe5b864cc265a0f5a14d (patch) | |
tree | ed51d670cbc2a896732bc9d5e2ecc867d450988e /scripts/get_maintainer.pl | |
parent | 2a68ff846164922196c38718ad8dc216819ccd38 (diff) | |
download | lwn-8ad0b83e0079564989ccbe5b864cc265a0f5a14d.tar.gz lwn-8ad0b83e0079564989ccbe5b864cc265a0f5a14d.zip |
ASoC: soc-core: remove always-false path
cppcheck throws the following warning:
sound/soc/soc-core.c:2773:6: style: Condition '!num_widgets' is always
false [knownConditionTrueFalse]
if (!num_widgets) {
^
sound/soc/soc-core.c:2761:18: note: Assuming that condition
'num_widgets<0' is not redundant
if (num_widgets < 0) {
^
sound/soc/soc-core.c:2766:18: note: Assuming condition is false
if (num_widgets & 1) {
^
sound/soc/soc-core.c:2772:2: note: Compound assignment '/=', assigned
value is 0
num_widgets /= 2;
^
We should check upfront all error conditions.
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Rander Wang <rander.wang@intel.com>
Reviewed-by: Péter Ujfalusi <peter.ujfalusi@linux.intel.com>
Link: https://lore.kernel.org/r/20220421162505.302132-1-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'scripts/get_maintainer.pl')
0 files changed, 0 insertions, 0 deletions