diff options
author | Takashi Iwai <tiwai@suse.de> | 2020-06-24 14:23:40 +0200 |
---|---|---|
committer | Takashi Iwai <tiwai@suse.de> | 2020-06-24 14:24:29 +0200 |
commit | 220345e98f1cdc768eeb6e3364a0fa7ab9647fe7 (patch) | |
tree | c3fd3927a037edc80b7ec782cd15e390089168fd /samples | |
parent | a32a1fc99807244d920d274adc46ba04b538cc8a (diff) | |
download | lwn-220345e98f1cdc768eeb6e3364a0fa7ab9647fe7.tar.gz lwn-220345e98f1cdc768eeb6e3364a0fa7ab9647fe7.zip |
ALSA: usb-audio: Fix OOB access of mixer element list
The USB-audio mixer code holds a linked list of usb_mixer_elem_list,
and several operations are performed for each mixer element. A few of
them (snd_usb_mixer_notify_id() and snd_usb_mixer_interrupt_v2())
assume each mixer element being a usb_mixer_elem_info object that is a
subclass of usb_mixer_elem_list, cast via container_of() and access it
members. This may result in an out-of-bound access when a
non-standard list element has been added, as spotted by syzkaller
recently.
This patch adds a new field, is_std_info, in usb_mixer_elem_list to
indicate that the element is the usb_mixer_elem_info type or not, and
skip the access to such an element if needed.
Reported-by: syzbot+fb14314433463ad51625@syzkaller.appspotmail.com
Reported-by: syzbot+2405ca3401e943c538b5@syzkaller.appspotmail.com
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20200624122340.9615-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'samples')
0 files changed, 0 insertions, 0 deletions