diff options
| author | Wedson Almeida Filho <walmeida@microsoft.com> | 2024-03-28 16:54:54 -0300 |
|---|---|---|
| committer | Miguel Ojeda <ojeda@kernel.org> | 2024-04-23 00:38:43 +0200 |
| commit | 323617f649c0966ad5e741e47e27e06d3a680d8f (patch) | |
| tree | 918c667f43d02da322a2af7299474c0961b45ef2 /rust | |
| parent | df70d04d56975f527b9c965322cf56e245909071 (diff) | |
| download | lwn-323617f649c0966ad5e741e47e27e06d3a680d8f.tar.gz lwn-323617f649c0966ad5e741e47e27e06d3a680d8f.zip | |
rust: kernel: require `Send` for `Module` implementations
The thread that calls the module initialisation code when a module is
loaded is not guaranteed [in fact, it is unlikely] to be the same one
that calls the module cleanup code on module unload, therefore, `Module`
implementations must be `Send` to account for them moving from one
thread to another implicitly.
Signed-off-by: Wedson Almeida Filho <walmeida@microsoft.com>
Reviewed-by: Alice Ryhl <aliceryhl@google.com>
Reviewed-by: Benno Lossin <benno.lossin@proton.me>
Cc: stable@vger.kernel.org # 6.8.x: df70d04d5697: rust: phy: implement `Send` for `Registration`
Cc: stable@vger.kernel.org
Fixes: 247b365dc8dc ("rust: add `kernel` crate")
Link: https://lore.kernel.org/r/20240328195457.225001-3-wedsonaf@gmail.com
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
Diffstat (limited to 'rust')
| -rw-r--r-- | rust/kernel/lib.rs | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/rust/kernel/lib.rs b/rust/kernel/lib.rs index be68d5e567b1..6858e2f8a3ed 100644 --- a/rust/kernel/lib.rs +++ b/rust/kernel/lib.rs @@ -65,7 +65,7 @@ const __LOG_PREFIX: &[u8] = b"rust_kernel\0"; /// The top level entrypoint to implementing a kernel module. /// /// For any teardown or cleanup operations, your type may implement [`Drop`]. -pub trait Module: Sized + Sync { +pub trait Module: Sized + Sync + Send { /// Called at module initialization time. /// /// Use this method to perform whatever setup or registration your module |