diff options
| author | Pablo Neira Ayuso <pablo@netfilter.org> | 2023-02-28 17:09:03 +0100 |
|---|---|---|
| committer | Pablo Neira Ayuso <pablo@netfilter.org> | 2023-03-01 17:23:23 +0100 |
| commit | 860e874290fb3be08e966c9c8ffc510c5b0f2bd8 (patch) | |
| tree | c20a082e5a7944bb51a1c81cc22421825413443e /net | |
| parent | 2067e7a00aa604b94de31d64f29b8893b1696f26 (diff) | |
| download | lwn-860e874290fb3be08e966c9c8ffc510c5b0f2bd8.tar.gz lwn-860e874290fb3be08e966c9c8ffc510c5b0f2bd8.zip | |
netfilter: nft_last: copy content when cloning expression
If the ruleset contains last timestamps, restore them accordingly.
Otherwise, listing after restoration shows never used items.
Fixes: 33a24de37e81 ("netfilter: nft_last: move stateful fields out of expression data")
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Diffstat (limited to 'net')
| -rw-r--r-- | net/netfilter/nft_last.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/net/netfilter/nft_last.c b/net/netfilter/nft_last.c index 7f2bda6641bd..8e6d7eaf9dc8 100644 --- a/net/netfilter/nft_last.c +++ b/net/netfilter/nft_last.c @@ -105,11 +105,15 @@ static void nft_last_destroy(const struct nft_ctx *ctx, static int nft_last_clone(struct nft_expr *dst, const struct nft_expr *src) { struct nft_last_priv *priv_dst = nft_expr_priv(dst); + struct nft_last_priv *priv_src = nft_expr_priv(src); priv_dst->last = kzalloc(sizeof(*priv_dst->last), GFP_ATOMIC); if (!priv_dst->last) return -ENOMEM; + priv_dst->last->set = priv_src->last->set; + priv_dst->last->jiffies = priv_src->last->jiffies; + return 0; } |