diff options
| author | Thomas Meyer <thomas@m3y3r.de> | 2011-11-17 12:43:40 +0000 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2011-11-21 15:02:17 -0500 |
| commit | 8524b001a21747c7df5c5a8404f0fbf45661ea44 (patch) | |
| tree | 78d4675486899b9b49c84e968c90f98e28c99f40 /net/irda | |
| parent | efd0bf97deeddd9ba53daabfc470a1399c6b0b2d (diff) | |
| download | lwn-8524b001a21747c7df5c5a8404f0fbf45661ea44.tar.gz lwn-8524b001a21747c7df5c5a8404f0fbf45661ea44.zip | |
irttp: Use kmemdup rather than duplicating its implementation
The semantic patch that makes this change is available
in scripts/coccinelle/api/memdup.cocci.
Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/irda')
| -rw-r--r-- | net/irda/irttp.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/net/irda/irttp.c b/net/irda/irttp.c index 32e3bb026110..5c93f2952b08 100644 --- a/net/irda/irttp.c +++ b/net/irda/irttp.c @@ -1461,14 +1461,12 @@ struct tsap_cb *irttp_dup(struct tsap_cb *orig, void *instance) } /* Allocate a new instance */ - new = kmalloc(sizeof(struct tsap_cb), GFP_ATOMIC); + new = kmemdup(orig, sizeof(struct tsap_cb), GFP_ATOMIC); if (!new) { IRDA_DEBUG(0, "%s(), unable to kmalloc\n", __func__); spin_unlock_irqrestore(&irttp->tsaps->hb_spinlock, flags); return NULL; } - /* Dup */ - memcpy(new, orig, sizeof(struct tsap_cb)); spin_lock_init(&new->lock); /* We don't need the old instance any more */ |