diff options
| author | David S. Miller <davem@davemloft.net> | 2010-08-30 18:35:24 -0700 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2010-08-30 18:37:56 -0700 |
| commit | 628e300cccaa628d8fb92aa28cb7530a3d5f2257 (patch) | |
| tree | 40f51d137174835b2e1240c81391bb18755d501f /net/irda | |
| parent | 7619b1b2e2b96842459f499fd48ec32e3d223d02 (diff) | |
| download | lwn-628e300cccaa628d8fb92aa28cb7530a3d5f2257.tar.gz lwn-628e300cccaa628d8fb92aa28cb7530a3d5f2257.zip | |
irda: Correctly clean up self->ias_obj on irda_bind() failure.
If irda_open_tsap() fails, the irda_bind() code tries to destroy
the ->ias_obj object by hand, but does so wrongly.
In particular, it fails to a) release the hashbin attached to the
object and b) reset the self->ias_obj pointer to NULL.
Fix both problems by using irias_delete_object() and explicitly
setting self->ias_obj to NULL, just as irda_release() does.
Reported-by: Tavis Ormandy <taviso@cmpxchg8b.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/irda')
| -rw-r--r-- | net/irda/af_irda.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/net/irda/af_irda.c b/net/irda/af_irda.c index 79986a674f6e..fd55b5135de5 100644 --- a/net/irda/af_irda.c +++ b/net/irda/af_irda.c @@ -824,8 +824,8 @@ static int irda_bind(struct socket *sock, struct sockaddr *uaddr, int addr_len) err = irda_open_tsap(self, addr->sir_lsap_sel, addr->sir_name); if (err < 0) { - kfree(self->ias_obj->name); - kfree(self->ias_obj); + irias_delete_object(self->ias_obj); + self->ias_obj = NULL; goto out; } |