diff options
| author | Jiri Benc <jbenc@redhat.com> | 2013-10-04 17:04:48 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2013-10-07 15:26:46 -0400 |
| commit | 0a7e22609067ff524fc7bbd45c6951dd08561667 (patch) | |
| tree | 22cdabcf72b03cdb44deed26aeaebe5a3438fc4e /net/ipv4/route.c | |
| parent | 281abd965fedfe7c31927d84e01a5bfa554b5502 (diff) | |
| download | lwn-0a7e22609067ff524fc7bbd45c6951dd08561667.tar.gz lwn-0a7e22609067ff524fc7bbd45c6951dd08561667.zip | |
ipv4: fix ineffective source address selection
When sending out multicast messages, the source address in inet->mc_addr is
ignored and rewritten by an autoselected one. This is caused by a typo in
commit 813b3b5db831 ("ipv4: Use caller's on-stack flowi as-is in output
route lookups").
Signed-off-by: Jiri Benc <jbenc@redhat.com>
Acked-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/route.c')
| -rw-r--r-- | net/ipv4/route.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ipv4/route.c b/net/ipv4/route.c index 727f4365bcdf..6011615e810d 100644 --- a/net/ipv4/route.c +++ b/net/ipv4/route.c @@ -2072,7 +2072,7 @@ struct rtable *__ip_route_output_key(struct net *net, struct flowi4 *fl4) RT_SCOPE_LINK); goto make_route; } - if (fl4->saddr) { + if (!fl4->saddr) { if (ipv4_is_multicast(fl4->daddr)) fl4->saddr = inet_select_addr(dev_out, 0, fl4->flowi4_scope); |