diff options
| author | Jakub Kicinski <kuba@kernel.org> | 2023-01-05 22:33:59 -0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2023-01-06 12:56:19 +0000 |
| commit | 6ef8f7da92750c3c25755fac39b561fff2d47378 (patch) | |
| tree | 16351d5cce74e1b1c03e8e065095a393f3a775b2 /net/devlink/core.c | |
| parent | 9053637e0da783efdb37bbfea6a27b856c0228d7 (diff) | |
| download | lwn-6ef8f7da92750c3c25755fac39b561fff2d47378.tar.gz lwn-6ef8f7da92750c3c25755fac39b561fff2d47378.zip | |
devlink: don't require setting features before registration
Requiring devlink_set_features() to be run before devlink is
registered is overzealous. devlink_set_features() itself is
a leftover from old workarounds which were trying to prevent
initiating reload before probe was complete.
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/devlink/core.c')
| -rw-r--r-- | net/devlink/core.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/net/devlink/core.c b/net/devlink/core.c index 7cf0b3efbb2f..a31a317626d7 100644 --- a/net/devlink/core.c +++ b/net/devlink/core.c @@ -125,8 +125,6 @@ next: */ void devlink_set_features(struct devlink *devlink, u64 features) { - ASSERT_DEVLINK_NOT_REGISTERED(devlink); - WARN_ON(features & DEVLINK_F_RELOAD && !devlink_reload_supported(devlink->ops)); devlink->features = features; |