diff options
| author | Hayes Wang <hayeswang@realtek.com> | 2024-09-03 14:33:33 +0800 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2024-09-04 16:34:06 -0700 |
| commit | 8487b4af59d4d7feda4b119dc2d92c67ca25c27e (patch) | |
| tree | ca6b9f4f30e56d18320080efd3215620d86e982d /net/bridge | |
| parent | 7e4196935069947d8b70b09c1660b67b067e75cb (diff) | |
| download | lwn-8487b4af59d4d7feda4b119dc2d92c67ca25c27e.tar.gz lwn-8487b4af59d4d7feda4b119dc2d92c67ca25c27e.zip | |
r8152: fix the firmware doesn't work
generic_ocp_write() asks the parameter "size" must be 4 bytes align.
Therefore, write the bp would fail, if the mac->bp_num is odd. Align the
size to 4 for fixing it. The way may write an extra bp, but the
rtl8152_is_fw_mac_ok() makes sure the value must be 0 for the bp whose
index is more than mac->bp_num. That is, there is no influence for the
firmware.
Besides, I check the return value of generic_ocp_write() to make sure
everything is correct.
Fixes: e5c266a61186 ("r8152: set bp in bulk")
Signed-off-by: Hayes Wang <hayeswang@realtek.com>
Link: https://patch.msgid.link/20240903063333.4502-1-hayeswang@realtek.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'net/bridge')
0 files changed, 0 insertions, 0 deletions