diff options
| author | Nikolay Aleksandrov <nikolay@cumulusnetworks.com> | 2016-06-27 18:34:42 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2016-06-29 05:33:35 -0400 |
| commit | 565ce8f32ac4a233b474f401e1d3e7e1de0a31fd (patch) | |
| tree | 7b36a16e2e9e4e75247305795110cc2b530731a9 /net/bridge | |
| parent | a3d2e9f8eb1487f4191ff08ce2d3d63702c65a90 (diff) | |
| download | lwn-565ce8f32ac4a233b474f401e1d3e7e1de0a31fd.tar.gz lwn-565ce8f32ac4a233b474f401e1d3e7e1de0a31fd.zip | |
net: bridge: fix vlan stats continue counter
I made a dumb off-by-one mistake when I added the vlan stats counter
dumping code. The increment should happen before the check, not after
otherwise we miss one entry when we continue dumping.
Fixes: a60c090361ea ("bridge: netlink: export per-vlan stats")
Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/bridge')
| -rw-r--r-- | net/bridge/br_netlink.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/bridge/br_netlink.c b/net/bridge/br_netlink.c index a5343c7232bf..85e89f693589 100644 --- a/net/bridge/br_netlink.c +++ b/net/bridge/br_netlink.c @@ -1273,7 +1273,7 @@ static int br_fill_linkxstats(struct sk_buff *skb, const struct net_device *dev, struct bridge_vlan_xstats vxi; struct br_vlan_stats stats; - if (vl_idx++ < *prividx) + if (++vl_idx < *prividx) continue; memset(&vxi, 0, sizeof(vxi)); vxi.vid = v->vid; |