diff options
| author | Jiapeng Chong <jiapeng.chong@linux.alibaba.com> | 2024-06-14 11:09:11 +0800 |
|---|---|---|
| committer | Herbert Xu <herbert@gondor.apana.org.au> | 2024-06-21 22:04:17 +1000 |
| commit | f0da7a231c7d0bafb6bb56da597cb2bfaf2c7028 (patch) | |
| tree | 7424fa182fd23edcc24689f86675339307127d0b /lib | |
| parent | 5ca95a907939f22467767829007b2707f50bba48 (diff) | |
| download | lwn-f0da7a231c7d0bafb6bb56da597cb2bfaf2c7028.tar.gz lwn-f0da7a231c7d0bafb6bb56da597cb2bfaf2c7028.zip | |
crypto: lib/mpi - Use swap() in mpi_ec_mul_point()
Use existing swap() function rather than duplicating its implementation.
./lib/crypto/mpi/ec.c:1291:20-21: WARNING opportunity for swap().
./lib/crypto/mpi/ec.c:1292:20-21: WARNING opportunity for swap().
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9328
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/crypto/mpi/ec.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/lib/crypto/mpi/ec.c b/lib/crypto/mpi/ec.c index e16dca1e23d5..4781f00982ef 100644 --- a/lib/crypto/mpi/ec.c +++ b/lib/crypto/mpi/ec.c @@ -1285,14 +1285,12 @@ void mpi_ec_mul_point(MPI_POINT result, sum = &p2_; for (j = nbits-1; j >= 0; j--) { - MPI_POINT t; - sw = mpi_test_bit(scalar, j); point_swap_cond(q1, q2, sw, ctx); montgomery_ladder(prd, sum, q1, q2, point->x, ctx); point_swap_cond(prd, sum, sw, ctx); - t = q1; q1 = prd; prd = t; - t = q2; q2 = sum; sum = t; + swap(q1, prd); + swap(q2, sum); } mpi_clear(result->y); |