summaryrefslogtreecommitdiff
path: root/kernel
diff options
context:
space:
mode:
authorYufan Chen <ericterminal@gmail.com>2026-03-30 23:34:28 +0800
committerAndrew Morton <akpm@linux-foundation.org>2026-04-15 02:15:01 -0700
commit5686459423d03d192134166f0ec45f98bb2d5d57 (patch)
tree0d9d045a1c3aaf3921344f460594e9dbbce3b09f /kernel
parente3a84be1ec2fd6f06e54bb31642412864d65280f (diff)
downloadlwn-5686459423d03d192134166f0ec45f98bb2d5d57.tar.gz
lwn-5686459423d03d192134166f0ec45f98bb2d5d57.zip
ocfs2/heartbeat: fix slot mapping rollback leaks on error paths
o2hb_map_slot_data() allocates hr_tmp_block, hr_slots, hr_slot_data, and pages in stages. If a later allocation fails, the current code returns without unwinding the earlier allocations. o2hb_region_dev_store() also leaves slot mapping resources behind when setup aborts, and it keeps hr_aborted_start/hr_node_deleted set across retries. That leaves stale state behind after a failed start. Factor the slot cleanup into o2hb_unmap_slot_data(), use it from both o2hb_map_slot_data() and o2hb_region_release(), and call it from the dev_store() rollback after stopping a started heartbeat thread. While freeing pages, clear each hr_slot_data entry as it is released, and reset the start state before each new setup attempt. This closes the slot mapping leak on allocation/setup failure paths and keeps failed setup attempts retryable. Link: https://lkml.kernel.org/r/20260330153428.19586-1-yufan.chen@linux.dev Signed-off-by: Yufan Chen <ericterminal@gmail.com> Reviewed-by: Joseph Qi <joseph.qi@linux.alibaba.com> Cc: Mark Fasheh <mark@fasheh.com> Cc: Joel Becker <jlbec@evilplan.org> Cc: Junxiao Bi <junxiao.bi@oracle.com> Cc: Changwei Ge <gechangwei@live.cn> Cc: Jun Piao <piaojun@huawei.com> Cc: Heming Zhao <heming.zhao@suse.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Diffstat (limited to 'kernel')
0 files changed, 0 insertions, 0 deletions