diff options
| author | Jiri Olsa <jolsa@kernel.org> | 2019-01-17 12:30:17 +0100 |
|---|---|---|
| committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2019-01-17 11:07:00 -0300 |
| commit | 99d86c8b88393e29cf07c020585f2c8afbcdd97d (patch) | |
| tree | b5864b2423de4c5d8231a7f3d20edfbea56658d7 /kernel/test_kprobes.c | |
| parent | 4e72ee8872279a70ebe973172133b98e8acbf54e (diff) | |
| download | lwn-99d86c8b88393e29cf07c020585f2c8afbcdd97d.tar.gz lwn-99d86c8b88393e29cf07c020585f2c8afbcdd97d.zip | |
perf ordered_events: Fix crash in ordered_events__free
Song Liu reported crash in 'perf record':
> #0 0x0000000000500055 in ordered_events(float, long double,...)(...) ()
> #1 0x0000000000500196 in ordered_events.reinit ()
> #2 0x00000000004fe413 in perf_session.process_events ()
> #3 0x0000000000440431 in cmd_record ()
> #4 0x00000000004a439f in run_builtin ()
> #5 0x000000000042b3e5 in main ()"
This can happen when we get out of buffers during event processing.
The subsequent ordered_events__free() call assumes oe->buffer != NULL
and crashes. Add a check to prevent that.
Reported-by: Song Liu <liu.song.a23@gmail.com>
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Reviewed-by: Song Liu <liu.song.a23@gmail.com>
Tested-by: Song Liu <liu.song.a23@gmail.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/r/20190117113017.12977-1-jolsa@kernel.org
Fixes: d5ceb62b3654 ("perf ordered_events: Add 'struct ordered_events_buffer' layer")
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'kernel/test_kprobes.c')
0 files changed, 0 insertions, 0 deletions