diff options
| author | Lucas De Marchi <demarchi@kernel.org> | 2026-03-30 08:13:52 -0500 |
|---|---|---|
| committer | Sami Tolvanen <samitolvanen@google.com> | 2026-04-04 00:04:48 +0000 |
| commit | 663385f9155f27892a97a5824006f806a32eb8dc (patch) | |
| tree | ca70708c4a43f67190244764580d8cd7b9a63a7f /kernel/module | |
| parent | 743f8cae549affe8eafb021b8c0e78a9f3bc23fa (diff) | |
| download | lwn-663385f9155f27892a97a5824006f806a32eb8dc.tar.gz lwn-663385f9155f27892a97a5824006f806a32eb8dc.zip | |
module: Simplify warning on positive returns from module_init()
It should now be rare to trigger this warning - it doesn't need to be so
verbose. Make it follow the usual style in the module loading code.
For the same reason, drop the dump_stack().
Suggested-by: Petr Pavlu <petr.pavlu@suse.com>
Signed-off-by: Lucas De Marchi <demarchi@kernel.org>
Reviewed-by: Aaron Tomlin <atomlin@atomlin.com>
Reviewed-by: Petr Pavlu <petr.pavlu@suse.com>
Reviewed-by: Daniel Gomez <da.gomez@samsung.com>
Signed-off-by: Sami Tolvanen <samitolvanen@google.com>
Diffstat (limited to 'kernel/module')
| -rw-r--r-- | kernel/module/main.c | 10 |
1 files changed, 3 insertions, 7 deletions
diff --git a/kernel/module/main.c b/kernel/module/main.c index ef6742536700..46dd8d25a605 100644 --- a/kernel/module/main.c +++ b/kernel/module/main.c @@ -3115,13 +3115,9 @@ static noinline int do_init_module(struct module *mod) goto fail_free_freeinit; } - if (ret > 0) { - pr_warn("%s: '%s'->init suspiciously returned %d, it should " - "follow 0/-E convention\n" - "%s: loading module anyway...\n", - __func__, mod->name, ret, __func__); - dump_stack(); - } + if (ret > 0) + pr_warn("%s: init suspiciously returned %d, it should follow 0/-E convention\n", + mod->name, ret); /* Now it's a first class citizen! */ mod->state = MODULE_STATE_LIVE; |