diff options
| author | David Wang <00107082@163.com> | 2024-05-17 14:24:05 +0800 |
|---|---|---|
| committer | Tejun Heo <tj@kernel.org> | 2024-05-26 08:48:11 -1000 |
| commit | a8d55ff5f3acf52e6380976fb5d0a9172032dcb0 (patch) | |
| tree | e8cf6b75117715a88c4dd087a700e5706dbd1773 /kernel/cgroup | |
| parent | 9f34c566027b623854dabc86fde052b44e5240be (diff) | |
| download | lwn-a8d55ff5f3acf52e6380976fb5d0a9172032dcb0.tar.gz lwn-a8d55ff5f3acf52e6380976fb5d0a9172032dcb0.zip | |
kernel/cgroup: cleanup cgroup_base_files when fail to add cgroup_psi_files
Even though css_clear_dir would be called to cleanup
all existing cgroup files when css_populate_dir failed,
reclaiming newly created cgroup files before
css_populate_dir returns with failure makes code more
consistent.
Signed-off-by: David Wang <00107082@163.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
Diffstat (limited to 'kernel/cgroup')
| -rw-r--r-- | kernel/cgroup/cgroup.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c index 9c9943ea5f89..4abd817b0c7c 100644 --- a/kernel/cgroup/cgroup.c +++ b/kernel/cgroup/cgroup.c @@ -1744,8 +1744,11 @@ static int css_populate_dir(struct cgroup_subsys_state *css) if (cgroup_psi_enabled()) { ret = cgroup_addrm_files(css, cgrp, cgroup_psi_files, true); - if (ret < 0) + if (ret < 0) { + cgroup_addrm_files(css, cgrp, + cgroup_base_files, false); return ret; + } } } else { ret = cgroup_addrm_files(css, cgrp, |