diff options
author | Konstantin Khlebnikov <khlebnikov@openvz.org> | 2011-12-08 14:33:51 -0800 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2011-12-09 07:50:27 -0800 |
commit | 635697c663f38106063d5659f0cf2e45afcd4bb5 (patch) | |
tree | 3aba50aabc16eeb63d5e21979a3fdf163ccabda2 /include/linux/shrinker.h | |
parent | 09d9673d53005fdf40de4c759425893904292236 (diff) | |
download | lwn-635697c663f38106063d5659f0cf2e45afcd4bb5.tar.gz lwn-635697c663f38106063d5659f0cf2e45afcd4bb5.zip |
vmscan: fix initial shrinker size handling
A shrinker function can return -1, means that it cannot do anything
without a risk of deadlock. For example prune_super() does this if it
cannot grab a superblock refrence, even if nr_to_scan=0. Currently we
interpret this -1 as a ULONG_MAX size shrinker and evaluate `total_scan'
according to this. So the next time around this shrinker can cause
really big pressure. Let's skip such shrinkers instead.
Also make total_scan signed, otherwise the check (total_scan < 0) below
never works.
Signed-off-by: Konstantin Khlebnikov <khlebnikov@openvz.org>
Cc: Dave Chinner <david@fromorbit.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'include/linux/shrinker.h')
0 files changed, 0 insertions, 0 deletions