diff options
| author | Namjae Jeon <linkinjeon@kernel.org> | 2026-05-06 20:36:37 +0900 |
|---|---|---|
| committer | Namjae Jeon <linkinjeon@kernel.org> | 2026-05-08 23:51:05 +0900 |
| commit | c37d9e68b6766f5e28057ee2ea3251b7ffe88e54 (patch) | |
| tree | cf9cf3edeabd2236ee68d610c1edf43deffa439f /fs/ntfs | |
| parent | 11f7a6d9d722aeb889f6363e4d07e9f0c54f1be1 (diff) | |
| download | lwn-c37d9e68b6766f5e28057ee2ea3251b7ffe88e54.tar.gz lwn-c37d9e68b6766f5e28057ee2ea3251b7ffe88e54.zip | |
ntfs: fix variable dereferenced before check ni in ntfs_attr_open()
Smatch warnings:
ntfs_attr_open() warn: variable dereferenced before check 'ni'
Moves the ntfs_debug() call after the NULL pointer checks to ensure safe
access to the structure members.
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
Diffstat (limited to 'fs/ntfs')
| -rw-r--r-- | fs/ntfs/attrib.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/fs/ntfs/attrib.c b/fs/ntfs/attrib.c index 7ab3571cc5f9..d60d0c686718 100644 --- a/fs/ntfs/attrib.c +++ b/fs/ntfs/attrib.c @@ -2913,12 +2913,12 @@ int ntfs_attr_open(struct ntfs_inode *ni, const __le32 type, struct ntfs_inode *base_ni; int err; - ntfs_debug("Entering for inode %lld, attr 0x%x.\n", - (unsigned long long)ni->mft_no, type); - if (!ni || !ni->vol) return -EINVAL; + ntfs_debug("Entering for inode %lld, attr 0x%x.\n", + ni->mft_no, type); + if (NInoAttr(ni)) base_ni = ni->ext.base_ntfs_ino; else |