summaryrefslogtreecommitdiff
path: root/fs/locks.c
diff options
context:
space:
mode:
authorTrond Myklebust <trond.myklebust@fys.uio.no>2006-08-14 08:54:48 -0700
committerGreg Kroah-Hartman <gregkh@suse.de>2006-08-14 13:10:59 -0700
commit74361cb6828398a96167b3234e186fbd731e5f30 (patch)
tree4455618d0f6c8f4e17484180a8f69b529c04076c /fs/locks.c
parent1d7ea7324ae7a59f8e17e4ba76a2707c1e6f24d2 (diff)
downloadlwn-74361cb6828398a96167b3234e186fbd731e5f30.tar.gz
lwn-74361cb6828398a96167b3234e186fbd731e5f30.zip
[PATCH] fcntl(F_SETSIG) fix
fcntl(F_SETSIG) no longer works on leases because lease_release_private_callback() gets called as the lease is copied in order to initialise it. The problem is that lease_alloc() performs an unnecessary initialisation, which sets the lease_manager_ops. Avoid the problem by allocating the target lease structure using locks_alloc_lock(). Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'fs/locks.c')
-rw-r--r--fs/locks.c6
1 files changed, 4 insertions, 2 deletions
diff --git a/fs/locks.c b/fs/locks.c
index b0b41a64e10b..d7c53392cac1 100644
--- a/fs/locks.c
+++ b/fs/locks.c
@@ -1421,8 +1421,9 @@ static int __setlease(struct file *filp, long arg, struct file_lock **flp)
if (!leases_enable)
goto out;
- error = lease_alloc(filp, arg, &fl);
- if (error)
+ error = -ENOMEM;
+ fl = locks_alloc_lock();
+ if (fl == NULL)
goto out;
locks_copy_lock(fl, lease);
@@ -1430,6 +1431,7 @@ static int __setlease(struct file *filp, long arg, struct file_lock **flp)
locks_insert_lock(before, fl);
*flp = fl;
+ error = 0;
out:
return error;
}