diff options
| author | Markus Elfring <elfring@users.sourceforge.net> | 2020-06-13 19:12:24 +0200 |
|---|---|---|
| committer | Theodore Ts'o <tytso@mit.edu> | 2020-08-06 00:08:56 -0400 |
| commit | e0f49d270d9d04beec113aa7cfacac6bddcb5765 (patch) | |
| tree | 3a663eed64cf3194c2521c2ef87c5ff63441147d /fs/ext4/xattr.c | |
| parent | e4d7f2d3593e703a4d58b813f332a5c2aef5106f (diff) | |
| download | lwn-e0f49d270d9d04beec113aa7cfacac6bddcb5765.tar.gz lwn-e0f49d270d9d04beec113aa7cfacac6bddcb5765.zip | |
ext4: delete unnecessary checks before brelse()
The brelse() function tests whether its argument is NULL
and then returns immediately.
Thus remove the tests which are not needed around the shown calls.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Reviewed-by: Ritesh Harjani <riteshh@linux.ibm.com>
Link: https://lore.kernel.org/r/0d713702-072f-a89c-20ec-ca70aa83a432@web.de
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Diffstat (limited to 'fs/ext4/xattr.c')
| -rw-r--r-- | fs/ext4/xattr.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/fs/ext4/xattr.c b/fs/ext4/xattr.c index 7d2f6576d954..cba4b877c606 100644 --- a/fs/ext4/xattr.c +++ b/fs/ext4/xattr.c @@ -1356,8 +1356,7 @@ retry: block = 0; while (wsize < bufsize) { - if (bh != NULL) - brelse(bh); + brelse(bh); csize = (bufsize - wsize) > blocksize ? blocksize : bufsize - wsize; bh = ext4_getblk(handle, ea_inode, block, 0); |