diff options
| author | Anand Jain <anand.jain@oracle.com> | 2023-02-11 00:15:54 +0800 |
|---|---|---|
| committer | David Sterba <dsterba@suse.com> | 2023-04-17 18:01:13 +0200 |
| commit | da8269a3e9edb8c57cd5448e07a5157872ddd143 (patch) | |
| tree | c242a78564c752b9548503d699f74f8ef42d980a /fs/btrfs/file-item.c | |
| parent | fa13661c48debbfb0a749e9328ea5648cf18fab4 (diff) | |
| download | lwn-da8269a3e9edb8c57cd5448e07a5157872ddd143.tar.gz lwn-da8269a3e9edb8c57cd5448e07a5157872ddd143.zip | |
btrfs: avoid reusing return variable in nested block in btrfs_lookup_bio_sums
The function btrfs_lookup_bio_sums() and a nested if statement declare
ret respectively as blk_status_t and int.
There is no need to store the return value of
search_file_offset_in_bio() to ret as this is a one-time call.
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Anand Jain <anand.jain@oracle.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs/btrfs/file-item.c')
| -rw-r--r-- | fs/btrfs/file-item.c | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/fs/btrfs/file-item.c b/fs/btrfs/file-item.c index 41c77a100853..89e9415b8f06 100644 --- a/fs/btrfs/file-item.c +++ b/fs/btrfs/file-item.c @@ -494,12 +494,11 @@ blk_status_t btrfs_lookup_bio_sums(struct btrfs_bio *bbio) if (inode->root->root_key.objectid == BTRFS_DATA_RELOC_TREE_OBJECTID) { u64 file_offset; - int ret; - ret = search_file_offset_in_bio(bio, - &inode->vfs_inode, - cur_disk_bytenr, &file_offset); - if (ret) + if (search_file_offset_in_bio(bio, + &inode->vfs_inode, + cur_disk_bytenr, + &file_offset)) set_extent_bits(io_tree, file_offset, file_offset + sectorsize - 1, EXTENT_NODATASUM); |