diff options
| author | Kent Overstreet <kent.overstreet@gmail.com> | 2022-02-26 11:48:34 -0500 |
|---|---|---|
| committer | Kent Overstreet <kent.overstreet@linux.dev> | 2023-10-22 17:09:26 -0400 |
| commit | 75ef2c59bc2f4d3c3ecd48286ac36ee7b868321c (patch) | |
| tree | 484bb617bb4d7b5cae6016e39b42ca70120a0abf /fs/bcachefs/sysfs.c | |
| parent | 734f7141ce45360203ddaa64782279653c1c9588 (diff) | |
| download | lwn-75ef2c59bc2f4d3c3ecd48286ac36ee7b868321c.tar.gz lwn-75ef2c59bc2f4d3c3ecd48286ac36ee7b868321c.zip | |
bcachefs: Start moving debug info from sysfs to debugfs
In sysfs, files can only output at most PAGE_SIZE. This is a problem for
debug info that needs to list an arbitrary number of times, and because
of this limit some of our debug info has been terser and harder to read
than we'd like.
This patch moves info about journal pins and cached btree nodes to
debugfs, and greatly expands and improves the output we return.
Signed-off-by: Kent Overstreet <kent.overstreet@gmail.com>
Diffstat (limited to 'fs/bcachefs/sysfs.c')
| -rw-r--r-- | fs/bcachefs/sysfs.c | 10 |
1 files changed, 0 insertions, 10 deletions
diff --git a/fs/bcachefs/sysfs.c b/fs/bcachefs/sysfs.c index ce32b9068518..3018250d421b 100644 --- a/fs/bcachefs/sysfs.c +++ b/fs/bcachefs/sysfs.c @@ -174,9 +174,7 @@ read_attribute(reserve_stats); read_attribute(btree_cache_size); read_attribute(compression_stats); read_attribute(journal_debug); -read_attribute(journal_pins); read_attribute(btree_updates); -read_attribute(dirty_btree_nodes); read_attribute(btree_cache); read_attribute(btree_key_cache); read_attribute(btree_transactions); @@ -402,15 +400,9 @@ SHOW(bch2_fs) if (attr == &sysfs_journal_debug) bch2_journal_debug_to_text(out, &c->journal); - if (attr == &sysfs_journal_pins) - bch2_journal_pins_to_text(out, &c->journal); - if (attr == &sysfs_btree_updates) bch2_btree_updates_to_text(out, c); - if (attr == &sysfs_dirty_btree_nodes) - bch2_dirty_btree_nodes_to_text(out, c); - if (attr == &sysfs_btree_cache) bch2_btree_cache_to_text(out, c); @@ -564,9 +556,7 @@ SYSFS_OPS(bch2_fs_internal); struct attribute *bch2_fs_internal_files[] = { &sysfs_journal_debug, - &sysfs_journal_pins, &sysfs_btree_updates, - &sysfs_dirty_btree_nodes, &sysfs_btree_cache, &sysfs_btree_key_cache, &sysfs_btree_transactions, |