diff options
| author | Kent Overstreet <kent.overstreet@linux.dev> | 2023-11-09 23:43:35 -0500 |
|---|---|---|
| committer | Kent Overstreet <kent.overstreet@linux.dev> | 2024-01-01 11:47:37 -0500 |
| commit | b27d7afb791715f4017f94c58168676c76398986 (patch) | |
| tree | 613d72e81ced64652f03b1df6a5f590cd8cffb1b /fs/bcachefs/recovery.c | |
| parent | b4b79b076445308389781a94934f411cb3e79c79 (diff) | |
| download | lwn-b27d7afb791715f4017f94c58168676c76398986.tar.gz lwn-b27d7afb791715f4017f94c58168676c76398986.zip | |
bcachefs: Don't flush journal after replay
The flush_all_pins() after journal replay was unecessary, and trying to
completely flush the journal while RW is not a great idea - it's not
guaranteed to terminate if other threads keep adding things to the
jorunal.
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
Diffstat (limited to 'fs/bcachefs/recovery.c')
| -rw-r--r-- | fs/bcachefs/recovery.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/fs/bcachefs/recovery.c b/fs/bcachefs/recovery.c index 5cbef7ad8cc8..a588092241ca 100644 --- a/fs/bcachefs/recovery.c +++ b/fs/bcachefs/recovery.c @@ -230,10 +230,8 @@ static int bch2_journal_replay(struct bch_fs *c) j->replay_journal_seq = 0; bch2_journal_set_replay_done(j); - bch2_journal_flush_all_pins(j); - ret = bch2_journal_error(j); - if (keys->nr && !ret) + if (keys->nr) bch2_journal_log_msg(c, "journal replay finished"); err: if (trans) |