diff options
| author | Kent Overstreet <kent.overstreet@gmail.com> | 2021-11-15 17:30:11 -0500 |
|---|---|---|
| committer | Kent Overstreet <kent.overstreet@linux.dev> | 2023-10-22 17:09:17 -0400 |
| commit | 9be1efe9c57e3eed5fc569caee47d0ddc96530db (patch) | |
| tree | a9c698a8218d0be18559a1722e3b4f2c7789cb9d /fs/bcachefs/recovery.c | |
| parent | f0c3f88b35e1fac6e3b7cec5635e43d4e595cf7a (diff) | |
| download | lwn-9be1efe9c57e3eed5fc569caee47d0ddc96530db.tar.gz lwn-9be1efe9c57e3eed5fc569caee47d0ddc96530db.zip | |
bcachefs: Fix error reporting from bch2_journal_flush_seq
- bch2_journal_halt() was unconditionally overwriting j->err_seq, the
sequence number that we failed to write
- journal_write_done was updating seq_ondisk and flushed_seq_ondisk even
for writes that errored, which broke the way bch2_journal_flush_seq_async()
locklessly checked for completions.
Signed-off-by: Kent Overstreet <kent.overstreet@gmail.com>
Diffstat (limited to 'fs/bcachefs/recovery.c')
| -rw-r--r-- | fs/bcachefs/recovery.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/bcachefs/recovery.c b/fs/bcachefs/recovery.c index be8912605527..c3b4d116275c 100644 --- a/fs/bcachefs/recovery.c +++ b/fs/bcachefs/recovery.c @@ -1480,7 +1480,7 @@ int bch2_fs_initialize(struct bch_fs *c) } err = "error writing first journal entry"; - ret = bch2_journal_meta(&c->journal); + ret = bch2_journal_flush(&c->journal); if (ret) goto err; |