diff options
| author | Kent Overstreet <kent.overstreet@linux.dev> | 2022-12-14 14:47:42 -0500 |
|---|---|---|
| committer | Kent Overstreet <kent.overstreet@linux.dev> | 2023-10-22 17:09:48 -0400 |
| commit | 1ba8a796b427d312aa68c2e04e00b42ec742883e (patch) | |
| tree | 575f1dd06ce6c49e99a8746ee066f8c6efc146ec /fs/bcachefs/recovery.c | |
| parent | 14d7d61fac9c151a270c6ef6f969993eae9f1bbf (diff) | |
| download | lwn-1ba8a796b427d312aa68c2e04e00b42ec742883e.tar.gz lwn-1ba8a796b427d312aa68c2e04e00b42ec742883e.zip | |
bcachefs: Recover from blacklisted journal entries
If it so happens that we crash while dirty, meaning we don't have the
superblock clean section, and we erroneously mark a journal entry we
wrote as blacklisted, we won't be able to recover.
This patch fixes this by adding a fallback: if we've got no superblock
clean section, and no non-ignored journal entries, we try the most
recent ignored journal entry.
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
Diffstat (limited to 'fs/bcachefs/recovery.c')
| -rw-r--r-- | fs/bcachefs/recovery.c | 10 |
1 files changed, 9 insertions, 1 deletions
diff --git a/fs/bcachefs/recovery.c b/fs/bcachefs/recovery.c index 15a676196e2f..976c336f294a 100644 --- a/fs/bcachefs/recovery.c +++ b/fs/bcachefs/recovery.c @@ -1137,7 +1137,15 @@ int bch2_fs_recovery(struct bch_fs *c) if (!last_journal_entry) { fsck_err_on(!c->sb.clean, c, "no journal entries found"); - goto use_clean; + if (clean) + goto use_clean; + + genradix_for_each_reverse(&c->journal_entries, iter, i) + if (*i) { + last_journal_entry = &(*i)->j; + (*i)->ignore = false; + break; + } } ret = journal_keys_sort(c); |