diff options
| author | Kent Overstreet <kent.overstreet@linux.dev> | 2023-07-10 11:17:56 -0400 |
|---|---|---|
| committer | Kent Overstreet <kent.overstreet@linux.dev> | 2023-10-22 17:10:06 -0400 |
| commit | 01e691e830edae9a145eeb70f8983223d606e2ca (patch) | |
| tree | 278d45c4b81de206eb65084fda747c7d7a40230d /fs/bcachefs/recovery.c | |
| parent | ba8eeae8eee0aae03eb6be0372519b72057d312c (diff) | |
| download | lwn-01e691e830edae9a145eeb70f8983223d606e2ca.tar.gz lwn-01e691e830edae9a145eeb70f8983223d606e2ca.zip | |
bcachefs: Fix a write buffer flush deadlock
We're not supposed to block if BTREE_INSERT_JOURNAL_RECLAIM && watermark
!= BCH_WATERMARK_reclaim.
This should really be a separate BTREE_INSERT_NONBLOCK flag - add some
comments to that effect, it's not important for this patch.
btree write buffer flush depends on this behaviour though - the first
loop tries to flush sequentially, which doesn't free up space in the
journal optimally. If that can't proceed we bail out and flush in
journal order - that won't work if we're blocked instead of returning an
error.
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
Diffstat (limited to 'fs/bcachefs/recovery.c')
0 files changed, 0 insertions, 0 deletions