diff options
| author | Kent Overstreet <kent.overstreet@linux.dev> | 2023-04-21 03:42:41 -0400 |
|---|---|---|
| committer | Kent Overstreet <kent.overstreet@linux.dev> | 2023-10-22 17:10:00 -0400 |
| commit | 1af5227c1d6b3513106f82808fe163bf0bd70df8 (patch) | |
| tree | 25dd5fa74804838da00d26291bc0f07fd155dfc1 /fs/bcachefs/move.h | |
| parent | 5a21764db13877eb1166baf12d2782ebb38b196e (diff) | |
| download | lwn-1af5227c1d6b3513106f82808fe163bf0bd70df8.tar.gz lwn-1af5227c1d6b3513106f82808fe163bf0bd70df8.zip | |
bcachefs: Kill bch2_verify_bucket_evacuated()
With backpointers, it's now impossible for bch2_evacuate_bucket() to be
completely reliable: it can race with an extent being partially
overwritten or split, which needs a new write buffer flush for the
backpointer to be seen.
This shouldn't be a real issue in practice; the previous patch added a
new tracepoint so we'll be able to see more easily if it is.
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
Diffstat (limited to 'fs/bcachefs/move.h')
| -rw-r--r-- | fs/bcachefs/move.h | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/fs/bcachefs/move.h b/fs/bcachefs/move.h index 50a6f7d7a292..547ee7b72c16 100644 --- a/fs/bcachefs/move.h +++ b/fs/bcachefs/move.h @@ -36,8 +36,6 @@ struct moving_context { wait_queue_head_t wait; }; -void bch2_verify_bucket_evacuated(struct btree_trans *, struct bpos, int); - #define move_ctxt_wait_event(_ctxt, _trans, _cond) \ do { \ bool cond_finished = false; \ |