diff options
| author | Kent Overstreet <kent.overstreet@linux.dev> | 2022-10-28 23:57:01 -0400 |
|---|---|---|
| committer | Kent Overstreet <kent.overstreet@linux.dev> | 2023-10-22 17:09:04 -0400 |
| commit | af171183194f73cca9a2f44ba13907ecc9c761a9 (patch) | |
| tree | d7d2d64bfa424ad5142801d46bf231794a10339d /fs/bcachefs/move.c | |
| parent | 7e94eeffe0e79a54e525ad05302eb454fb96affd (diff) | |
| download | lwn-af171183194f73cca9a2f44ba13907ecc9c761a9.tar.gz lwn-af171183194f73cca9a2f44ba13907ecc9c761a9.zip | |
bcachefs: Kill bch_write_op.index_update_fn
This deletes bch_write_op.index_update_fn: indirect function calls have
gotten considerably more expensive post spectre/meltdown, and we only
have two different index_update_fns - this patch adds a flag to specify
which one to use (normal vs. data move path).
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
Diffstat (limited to 'fs/bcachefs/move.c')
| -rw-r--r-- | fs/bcachefs/move.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/fs/bcachefs/move.c b/fs/bcachefs/move.c index 8807b18ddc43..61c9be4acd5f 100644 --- a/fs/bcachefs/move.c +++ b/fs/bcachefs/move.c @@ -52,7 +52,7 @@ struct moving_context { wait_queue_head_t wait; }; -static int bch2_migrate_index_update(struct bch_write_op *op) +int bch2_migrate_index_update(struct bch_write_op *op) { struct bch_fs *c = op->c; struct btree_trans trans; @@ -266,11 +266,11 @@ int bch2_migrate_write_init(struct bch_fs *c, struct migrate_write *m, m->op.flags |= BCH_WRITE_PAGES_STABLE| BCH_WRITE_PAGES_OWNED| BCH_WRITE_DATA_ENCODED| - BCH_WRITE_FROM_INTERNAL; + BCH_WRITE_FROM_INTERNAL| + BCH_WRITE_MOVE; m->op.nr_replicas = data_opts.nr_replicas; m->op.nr_replicas_required = data_opts.nr_replicas; - m->op.index_update_fn = bch2_migrate_index_update; switch (data_cmd) { case DATA_ADD_REPLICAS: { |