diff options
| author | Kent Overstreet <kent.overstreet@gmail.com> | 2021-01-16 15:40:33 -0500 |
|---|---|---|
| committer | Kent Overstreet <kent.overstreet@linux.dev> | 2023-10-22 17:08:51 -0400 |
| commit | 280249b9d9b9a62562ddeb5429a7d29d2f03ba1c (patch) | |
| tree | 3f67835c9f401afb6062d819a4ace409ae7d7144 /fs/bcachefs/io.c | |
| parent | ed9d58a2b1ddbc38816571638ee114b7efb9f279 (diff) | |
| download | lwn-280249b9d9b9a62562ddeb5429a7d29d2f03ba1c.tar.gz lwn-280249b9d9b9a62562ddeb5429a7d29d2f03ba1c.zip | |
bcachefs: Correctly order flushes and journal writes on multi device filesystems
All writes prior to a journal write need to be flushed before the
journal write itself happens. On single device filesystems, it suffices
to mark the write with REQ_PREFLUSH|REQ_FUA, but on multi device
filesystems we need to issue flushes to every device - and wait for them
to complete - before issuing the journal writes. Previously, we were
issuing flushes to every device, but we weren't waiting for them to
complete before issuing the journal writes.
Signed-off-by: Kent Overstreet <kent.overstreet@gmail.com>
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
Diffstat (limited to 'fs/bcachefs/io.c')
| -rw-r--r-- | fs/bcachefs/io.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/fs/bcachefs/io.c b/fs/bcachefs/io.c index bc1e2dc04850..8a4d05eee381 100644 --- a/fs/bcachefs/io.c +++ b/fs/bcachefs/io.c @@ -509,9 +509,6 @@ void bch2_submit_wbio_replicas(struct bch_write_bio *wbio, struct bch_fs *c, n->submit_time = local_clock(); n->bio.bi_iter.bi_sector = ptr->offset; - if (!journal_flushes_device(ca)) - n->bio.bi_opf |= REQ_FUA; - if (likely(n->have_ioref)) { this_cpu_add(ca->io_done->sectors[WRITE][type], bio_sectors(&n->bio)); |