diff options
author | Kent Overstreet <kent.overstreet@gmail.com> | 2020-11-11 12:33:12 -0500 |
---|---|---|
committer | Kent Overstreet <kent.overstreet@linux.dev> | 2023-10-22 17:08:46 -0400 |
commit | eb8e6e9ccbb4ba37c04a7cff032975b4df7d63c7 (patch) | |
tree | 946041b0c3ce44e48e4968840527b11e2d1c25d8 /fs/bcachefs/fs.c | |
parent | 6d9378f3dcd7b91effdc4ffe1da1a2e8987e9f1e (diff) | |
download | lwn-eb8e6e9ccbb4ba37c04a7cff032975b4df7d63c7.tar.gz lwn-eb8e6e9ccbb4ba37c04a7cff032975b4df7d63c7.zip |
bcachefs: Deadlock prevention for ei_pagecache_lock
In the dio write path, when get_user_pages() invokes the fault handler
we have a recursive locking situation - we have to handle the lock
ordering ourselves or we have a deadlock: this patch addresses that by
checking for locking ordering violations and doing the unlock/relock
dance if necessary.
Signed-off-by: Kent Overstreet <kent.overstreet@gmail.com>
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
Diffstat (limited to 'fs/bcachefs/fs.c')
-rw-r--r-- | fs/bcachefs/fs.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/fs/bcachefs/fs.c b/fs/bcachefs/fs.c index 3e3ab4e53f33..231a5433577f 100644 --- a/fs/bcachefs/fs.c +++ b/fs/bcachefs/fs.c @@ -93,6 +93,11 @@ void bch2_pagecache_add_put(struct pagecache_lock *lock) __pagecache_lock_put(lock, 1); } +bool bch2_pagecache_add_tryget(struct pagecache_lock *lock) +{ + return __pagecache_lock_tryget(lock, 1); +} + void bch2_pagecache_add_get(struct pagecache_lock *lock) { __pagecache_lock_get(lock, 1); |