diff options
| author | Yuxuan Shui <yshuiv7@gmail.com> | 2020-05-22 15:50:05 +0100 |
|---|---|---|
| committer | Kent Overstreet <kent.overstreet@linux.dev> | 2023-10-22 17:08:39 -0400 |
| commit | 22d8a33d30d7a28d0dd972f36cc48b80f585d67b (patch) | |
| tree | 36d60ba534da1928bb60d66a188a10b6f702c048 /fs/bcachefs/fs.c | |
| parent | a1b0da4555c16bf274f705dc76c9b297f54bf6c8 (diff) | |
| download | lwn-22d8a33d30d7a28d0dd972f36cc48b80f585d67b.tar.gz lwn-22d8a33d30d7a28d0dd972f36cc48b80f585d67b.zip | |
bcachefs: fix stack corruption
When a bkey_on_stack is passed to bch_read_indirect_extent, there is no
guarantee that it will be big enough to hold the bkey. And
bch_read_indirect_extent is not aware of bkey_on_stack to call realloc
on it. This cause a stack corruption.
This commit makes bch_read_indirect_extent aware of bkey_on_stack so it
can call realloc when appropriate.
Tested-by: Yuxuan Shui <yshuiv7@gmail.com>
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
Diffstat (limited to 'fs/bcachefs/fs.c')
| -rw-r--r-- | fs/bcachefs/fs.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/bcachefs/fs.c b/fs/bcachefs/fs.c index 4458a98b78ee..6aff3203b4e1 100644 --- a/fs/bcachefs/fs.c +++ b/fs/bcachefs/fs.c @@ -918,7 +918,7 @@ retry: sectors = k.k->size - offset_into_extent; ret = bch2_read_indirect_extent(&trans, - &offset_into_extent, cur.k); + &offset_into_extent, &cur); if (ret) break; |