diff options
| author | Kent Overstreet <kent.overstreet@gmail.com> | 2022-04-08 23:54:14 -0400 |
|---|---|---|
| committer | Kent Overstreet <kent.overstreet@linux.dev> | 2023-10-22 17:09:31 -0400 |
| commit | 7c4ca54ae68c4ae24dbfb8b209657a5249a5f0b7 (patch) | |
| tree | 0fd510f51ea0754e9c0b3a38eb7ba30c33dc80b9 /fs/bcachefs/fs-io.c | |
| parent | 84c72755b9aab31ed43e50eb5c7229d7ef042f7d (diff) | |
| download | lwn-7c4ca54ae68c4ae24dbfb8b209657a5249a5f0b7.tar.gz lwn-7c4ca54ae68c4ae24dbfb8b209657a5249a5f0b7.zip | |
bcachefs: Don't skip triggers in fcollapse()
With backpointers this doesn't work anymore - backpointers always need
to be updated to point to the new extent position.
Signed-off-by: Kent Overstreet <kent.overstreet@gmail.com>
Diffstat (limited to 'fs/bcachefs/fs-io.c')
| -rw-r--r-- | fs/bcachefs/fs-io.c | 8 |
1 files changed, 1 insertions, 7 deletions
diff --git a/fs/bcachefs/fs-io.c b/fs/bcachefs/fs-io.c index 14550ac610c6..85a4484bec65 100644 --- a/fs/bcachefs/fs-io.c +++ b/fs/bcachefs/fs-io.c @@ -2894,13 +2894,7 @@ reassemble: next_pos = insert ? bkey_start_pos(&delete.k) : delete.k.p; - if (copy.k->k.size == k.k->size) { - /* - * If we're moving the entire extent, we can skip - * running triggers: - */ - trigger_flags |= BTREE_TRIGGER_NORUN; - } else { + if (copy.k->k.size != k.k->size) { /* We might end up splitting compressed extents: */ unsigned nr_ptrs = bch2_bkey_nr_ptrs_allocated(bkey_i_to_s_c(copy.k)); |