diff options
| author | Kent Overstreet <kent.overstreet@gmail.com> | 2021-01-17 13:19:16 -0500 |
|---|---|---|
| committer | Kent Overstreet <kent.overstreet@linux.dev> | 2023-10-22 17:08:51 -0400 |
| commit | cd9f3dfe58709c7b0793a706d0dd0292a66237d5 (patch) | |
| tree | 76d513b1dec713a0ae6e5954dbcfbb1b215aa119 /fs/bcachefs/buckets.c | |
| parent | 280249b9d9b9a62562ddeb5429a7d29d2f03ba1c (diff) | |
| download | lwn-cd9f3dfe58709c7b0793a706d0dd0292a66237d5.tar.gz lwn-cd9f3dfe58709c7b0793a706d0dd0292a66237d5.zip | |
bcachefs: Fix integer overflow in bch2_disk_reservation_get()
The sectors argument shouldn't have been a u32 - it can be up to U32_MAX
(i.e. fallocate creating persistent reservations), and if replication is
enabled we'll overflow when we calculate the real number of sectors to
reserve. Oops.
Signed-off-by: Kent Overstreet <kent.overstreet@gmail.com>
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
Diffstat (limited to 'fs/bcachefs/buckets.c')
| -rw-r--r-- | fs/bcachefs/buckets.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/bcachefs/buckets.c b/fs/bcachefs/buckets.c index 1bbd1ee080ec..11907abd9b4c 100644 --- a/fs/bcachefs/buckets.c +++ b/fs/bcachefs/buckets.c @@ -2109,7 +2109,7 @@ int bch2_trans_mark_update(struct btree_trans *trans, #define SECTORS_CACHE 1024 int bch2_disk_reservation_add(struct bch_fs *c, struct disk_reservation *res, - unsigned sectors, int flags) + u64 sectors, int flags) { struct bch_fs_pcpu *pcpu; u64 old, v, get; |