diff options
| author | Kent Overstreet <kent.overstreet@gmail.com> | 2021-04-14 13:26:15 -0400 |
|---|---|---|
| committer | Kent Overstreet <kent.overstreet@linux.dev> | 2023-10-22 17:09:00 -0400 |
| commit | 2527dd91580b1eb5ff1f8df1b47817ac60395830 (patch) | |
| tree | 010df60c971735284954e484109dbac249db7a3a /fs/bcachefs/btree_iter.h | |
| parent | 0ef107859bc868f783cbbbf055a907c702896661 (diff) | |
| download | lwn-2527dd91580b1eb5ff1f8df1b47817ac60395830.tar.gz lwn-2527dd91580b1eb5ff1f8df1b47817ac60395830.zip | |
bcachefs: Improve bch2_btree_iter_traverse_all()
By changing it to upgrade iterators to intent locks to avoid lock
restarts we can simplify __bch2_btree_node_lock() quite a bit - this
fixes a probable bug where it could potentially drop a lock on an
unrelated error but still succeed instead of causing a transaction
restart.
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
Diffstat (limited to 'fs/bcachefs/btree_iter.h')
| -rw-r--r-- | fs/bcachefs/btree_iter.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/bcachefs/btree_iter.h b/fs/bcachefs/btree_iter.h index 07d9b6d36e51..2f63adb9e420 100644 --- a/fs/bcachefs/btree_iter.h +++ b/fs/bcachefs/btree_iter.h @@ -187,7 +187,7 @@ static inline int btree_iter_lock_cmp(const struct btree_iter *l, { return cmp_int(l->btree_id, r->btree_id) ?: -cmp_int(btree_iter_is_cached(l), btree_iter_is_cached(r)) ?: - bkey_cmp(l->pos, r->pos); + bkey_cmp(l->real_pos, r->real_pos); } /* |