diff options
| author | Loic Poulain <loic.poulain@intel.com> | 2014-06-23 17:42:44 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2014-07-28 08:05:56 -0700 |
| commit | 32c24ed1f0b34c1c05df46029eccef426b20f3e5 (patch) | |
| tree | d254bbe65f80873710cc2234417fefcc94e3e209 /drivers | |
| parent | d887a032c8d56b4b525f698ac2354876f6a4a5b4 (diff) | |
| download | lwn-32c24ed1f0b34c1c05df46029eccef426b20f3e5.tar.gz lwn-32c24ed1f0b34c1c05df46029eccef426b20f3e5.zip | |
Bluetooth: Ignore H5 non-link packets in non-active state
commit 48439d501e3d9e8634bdc0c418e066870039599d upstream.
When detecting a non-link packet, h5_reset_rx() frees the Rx skb.
Not returning after that will cause the upcoming h5_rx_payload()
call to dereference a now NULL Rx skb and trigger a kernel oops.
Signed-off-by: Loic Poulain <loic.poulain@intel.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/bluetooth/hci_h5.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/bluetooth/hci_h5.c b/drivers/bluetooth/hci_h5.c index f6f497450560..e36a0245f2c1 100644 --- a/drivers/bluetooth/hci_h5.c +++ b/drivers/bluetooth/hci_h5.c @@ -406,6 +406,7 @@ static int h5_rx_3wire_hdr(struct hci_uart *hu, unsigned char c) H5_HDR_PKT_TYPE(hdr) != HCI_3WIRE_LINK_PKT) { BT_ERR("Non-link packet received in non-active state"); h5_reset_rx(h5); + return 0; } h5->rx_func = h5_rx_payload; |