diff options
| author | Toshi Kani <toshi.kani@hp.com> | 2012-08-27 12:52:24 -0600 |
|---|---|---|
| committer | Wim Van Sebroeck <wim@iguana.be> | 2012-09-10 17:28:08 +0200 |
| commit | 308b135e4fcc00c80c07e0e04e7afa8edf78583c (patch) | |
| tree | 37aae22d47d5e328a6048937ca382a7886ef1e56 /drivers/watchdog | |
| parent | 55d512e245bc7699a8800e23df1a24195dd08217 (diff) | |
| download | lwn-308b135e4fcc00c80c07e0e04e7afa8edf78583c.tar.gz lwn-308b135e4fcc00c80c07e0e04e7afa8edf78583c.zip | |
hpwdt: Fix kdump issue in hpwdt
kdump can be interrupted by watchdog timer when the timer is left
activated on the crash kernel. Changed the hpwdt driver to disable
watchdog timer at boot-time. This assures that watchdog timer is
disabled until /dev/watchdog is opened, and prevents watchdog timer
to be left running on the crash kernel.
Signed-off-by: Toshi Kani <toshi.kani@hp.com>
Tested-by: Lisa Mitchell <lisa.mitchell@hp.com>
Signed-off-by: Thomas Mingarelli <Thomas.Mingarelli@hp.com>
Signed-off-by: Wim Van Sebroeck <wim@iguana.be>
Cc: stable <stable@vger.kernel.org>
Diffstat (limited to 'drivers/watchdog')
| -rw-r--r-- | drivers/watchdog/hpwdt.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c index 1eff743ec497..ae60406ea8a1 100644 --- a/drivers/watchdog/hpwdt.c +++ b/drivers/watchdog/hpwdt.c @@ -814,6 +814,9 @@ static int __devinit hpwdt_init_one(struct pci_dev *dev, hpwdt_timer_reg = pci_mem_addr + 0x70; hpwdt_timer_con = pci_mem_addr + 0x72; + /* Make sure that timer is disabled until /dev/watchdog is opened */ + hpwdt_stop(); + /* Make sure that we have a valid soft_margin */ if (hpwdt_change_timer(soft_margin)) hpwdt_change_timer(DEFAULT_MARGIN); |