diff options
| author | Flavio Suligoi <f.suligoi@asem.it> | 2023-11-29 17:45:14 +0100 |
|---|---|---|
| committer | Lee Jones <lee@kernel.org> | 2023-12-01 11:24:21 +0000 |
| commit | ab47505ce45b869ab649024dc932e981fcdd6e5f (patch) | |
| tree | 7f5317ce33e37099cd9e9ed932d8cf55a844677b /drivers/video | |
| parent | 58793f263abc8e5233fabf7466219202db09d048 (diff) | |
| download | lwn-ab47505ce45b869ab649024dc932e981fcdd6e5f.tar.gz lwn-ab47505ce45b869ab649024dc932e981fcdd6e5f.zip | |
backlight: mp3309c: Fix uninitialized local variable
In the function "pm3309c_parse_dt_node", when the dimming analog control
mode (by I2C messages) is enabled, the local variable "prop_levels" is
tested without any initialization, as indicated by the following smatch
warning:
drivers/video/backlight/mp3309c.c:279 pm3309c_parse_dt_node() error: uninitialized symbol 'prop_levels'.
To avoid any problem in case of undefined behavior, we need to initialize
it to "NULL".
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/dri-devel/af0a1870-693b-442f-9b11-0503cfcd944a@moroto.mountain/
Fixes: 2e914516a58c ("backlight: mp3309c: Add support for MPS MP3309C")
Signed-off-by: Flavio Suligoi <f.suligoi@asem.it>
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
Link: https://lore.kernel.org/r/20231129164514.2772719-1-f.suligoi@asem.it
Signed-off-by: Lee Jones <lee@kernel.org>
Diffstat (limited to 'drivers/video')
| -rw-r--r-- | drivers/video/backlight/mp3309c.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/video/backlight/mp3309c.c b/drivers/video/backlight/mp3309c.c index 3fe4469ef43f..34d71259fac1 100644 --- a/drivers/video/backlight/mp3309c.c +++ b/drivers/video/backlight/mp3309c.c @@ -203,7 +203,8 @@ static int pm3309c_parse_dt_node(struct mp3309c_chip *chip, struct mp3309c_platform_data *pdata) { struct device_node *node = chip->dev->of_node; - struct property *prop_pwms, *prop_levels; + struct property *prop_pwms; + struct property *prop_levels = NULL; int length = 0; int ret, i; unsigned int num_levels, tmp_value; |