diff options
| author | Cai Huoqing <caihuoqing@baidu.com> | 2021-09-17 12:22:12 +0800 |
|---|---|---|
| committer | Helge Deller <deller@gmx.de> | 2022-01-29 23:22:36 +0100 |
| commit | 81b63420564da2e4912733a966e87d6022ff313a (patch) | |
| tree | c6b937ede8a8683148a1606e47c0e175fb2dee32 /drivers/video/fbdev/mmp | |
| parent | b1d8c84abb38564171694564a325734893493894 (diff) | |
| download | lwn-81b63420564da2e4912733a966e87d6022ff313a.tar.gz lwn-81b63420564da2e4912733a966e87d6022ff313a.zip | |
video: fbdev: mmp: Make use of the helper function dev_err_probe()
When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
Using dev_err_probe() can reduce code size, and the error value
gets printed.
Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
Signed-off-by: Helge Deller <deller@gmx.de>
Diffstat (limited to 'drivers/video/fbdev/mmp')
| -rw-r--r-- | drivers/video/fbdev/mmp/hw/mmp_ctrl.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/video/fbdev/mmp/hw/mmp_ctrl.c b/drivers/video/fbdev/mmp/hw/mmp_ctrl.c index 061a105afb86..a9df8ee79810 100644 --- a/drivers/video/fbdev/mmp/hw/mmp_ctrl.c +++ b/drivers/video/fbdev/mmp/hw/mmp_ctrl.c @@ -514,7 +514,8 @@ static int mmphw_probe(struct platform_device *pdev) /* get clock */ ctrl->clk = devm_clk_get(ctrl->dev, mi->clk_name); if (IS_ERR(ctrl->clk)) { - dev_err(ctrl->dev, "unable to get clk %s\n", mi->clk_name); + dev_err_probe(ctrl->dev, ret, + "unable to get clk %s\n", mi->clk_name); ret = -ENOENT; goto failed; } |