diff options
| author | Muhammad Usama Anjum <musamaanjum@gmail.com> | 2021-02-11 15:50:26 +0500 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2021-02-11 13:53:07 +0100 |
| commit | 5e911c3d9dbc96b3e55fe1695107aff3671f53bd (patch) | |
| tree | 9580855f3bbf9f8d3c22cd9c913b57d0e44734c0 /drivers/staging | |
| parent | bc8392e33d9a6f38e5370815c8d21e3be7e57d8a (diff) | |
| download | lwn-5e911c3d9dbc96b3e55fe1695107aff3671f53bd.tar.gz lwn-5e911c3d9dbc96b3e55fe1695107aff3671f53bd.zip | |
staging: wfx: avoid defining array of flexible struct
In this particular case, the struct element is already flexible struct.
Thus struct element ie[] is ambiguous inside another struct. The members
of struct element ie aren't being accessed in code anywhere. The data of
u8 type is copied in it. So it has been changed to u8 ie[] to make the
sparse happy and code simple.
Warning from sparse:
drivers/stagingwfx/hif_tx.c: note: in included file (through drivers/stagingwfx/data_tx.h, drivers/staging//wfx/wfx.h):
drivers/staging//wfx/hif_api_cmd.h:103:26: warning: array of flexible structures
Reviewed-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
Signed-off-by: Muhammad Usama Anjum <musamaanjum@gmail.com>
Link: https://lore.kernel.org/r/20210211105026.GA45458@LEGION
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging')
| -rw-r--r-- | drivers/staging/wfx/hif_api_cmd.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/staging/wfx/hif_api_cmd.h b/drivers/staging/wfx/hif_api_cmd.h index 11bc1a58edae..58c9bb036011 100644 --- a/drivers/staging/wfx/hif_api_cmd.h +++ b/drivers/staging/wfx/hif_api_cmd.h @@ -100,7 +100,7 @@ struct hif_req_update_ie { u8 reserved1:5; u8 reserved2; __le16 num_ies; - struct element ie[]; + u8 ie[]; } __packed; struct hif_cnf_update_ie { |