diff options
| author | Lv Yunlong <lyl2019@mail.ustc.edu.cn> | 2021-03-10 22:46:36 -0800 |
|---|---|---|
| committer | Martin K. Petersen <martin.petersen@oracle.com> | 2021-03-15 22:50:49 -0400 |
| commit | c8c165dea4c8f5ad67b1240861e4f6c5395fa4ac (patch) | |
| tree | 3c856f5652495b01837d926807af944a5de4e988 /drivers/scsi/st.c | |
| parent | 2bb817712e2f77486d6ee17e7efaf91997a685f8 (diff) | |
| download | lwn-c8c165dea4c8f5ad67b1240861e4f6c5395fa4ac.tar.gz lwn-c8c165dea4c8f5ad67b1240861e4f6c5395fa4ac.zip | |
scsi: st: Fix a use after free in st_open()
In st_open(), if STp->in_use is true, STp will be freed by
scsi_tape_put(). However, STp is still used by DEBC_printk() after. It is
better to DEBC_printk() before scsi_tape_put().
Link: https://lore.kernel.org/r/20210311064636.10522-1-lyl2019@mail.ustc.edu.cn
Acked-by: Kai Mäkisara <kai.makisara@kolumbus.fi>
Signed-off-by: Lv Yunlong <lyl2019@mail.ustc.edu.cn>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'drivers/scsi/st.c')
| -rw-r--r-- | drivers/scsi/st.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/scsi/st.c b/drivers/scsi/st.c index 841ad2fc369a..9ca536aae784 100644 --- a/drivers/scsi/st.c +++ b/drivers/scsi/st.c @@ -1269,8 +1269,8 @@ static int st_open(struct inode *inode, struct file *filp) spin_lock(&st_use_lock); if (STp->in_use) { spin_unlock(&st_use_lock); - scsi_tape_put(STp); DEBC_printk(STp, "Device already in use.\n"); + scsi_tape_put(STp); return (-EBUSY); } |