diff options
| author | Hugh Daschbach <hdasch@broadcom.com> | 2010-01-21 10:15:55 -0800 |
|---|---|---|
| committer | James Bottomley <James.Bottomley@suse.de> | 2010-02-17 09:57:01 -0600 |
| commit | b248df30fca3aeee1d650b570e8cbc4e8cc45710 (patch) | |
| tree | fefe362a9c9513aa3a0e59a643827952d5ad383e /drivers/scsi/libfc/fc_lport.c | |
| parent | 3b709150b73205710d05128b925090aac048ed23 (diff) | |
| download | lwn-b248df30fca3aeee1d650b570e8cbc4e8cc45710.tar.gz lwn-b248df30fca3aeee1d650b570e8cbc4e8cc45710.zip | |
[SCSI] libfc: Don't assume response request present.
Fix NULL pointer dereference crash occurs in fc_lport_bsg_request()
for bsg requests that do not contain a response request.
Specifically, FC_BSG_HST_ADD_RPORT and FC_BSG_HST_DEL_RPORT bsg
requests are not guaranteed to include a response request.
Signed-off-by: Hugh Daschbach <hdasch@broadcom.com>
Signed-off-by: Robert Love <robert.w.love@intel.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
Diffstat (limited to 'drivers/scsi/libfc/fc_lport.c')
| -rw-r--r-- | drivers/scsi/libfc/fc_lport.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/scsi/libfc/fc_lport.c b/drivers/scsi/libfc/fc_lport.c index 0b165024a219..7ec8ce75007c 100644 --- a/drivers/scsi/libfc/fc_lport.c +++ b/drivers/scsi/libfc/fc_lport.c @@ -1800,7 +1800,8 @@ int fc_lport_bsg_request(struct fc_bsg_job *job) u32 did; job->reply->reply_payload_rcv_len = 0; - rsp->resid_len = job->reply_payload.payload_len; + if (rsp) + rsp->resid_len = job->reply_payload.payload_len; mutex_lock(&lport->lp_mutex); |