diff options
| author | Martin Schwidefsky <schwidefsky@de.ibm.com> | 2016-05-02 14:53:29 +0200 |
|---|---|---|
| committer | Martin Schwidefsky <schwidefsky@de.ibm.com> | 2016-05-04 16:29:53 +0200 |
| commit | 8340ab60b3624386eaa24fa21bdb4e6775066ccf (patch) | |
| tree | d0e7952f4a44d6733e448006f8a8fc442f1c08c5 /drivers/s390/char/tty3270.c | |
| parent | 2e63a3a66655d5fe5d85c090b009979870436c00 (diff) | |
| download | lwn-8340ab60b3624386eaa24fa21bdb4e6775066ccf.tar.gz lwn-8340ab60b3624386eaa24fa21bdb4e6775066ccf.zip | |
s390/3270: avoid endless I/O loop with disconnected 3270 terminals
If a 3270 terminal is disconnected while the tty view is active
the 3270 driver goes into an endless loop of failed I/O requests
until the terminal is connected again.
Add code to the raw3270 interrupt handler to check for unit checks
due to failed I/O requests and put the device to sleep with the
RAW3270_FLAGS_BUSY flag until a unsolicited device end interrupt
indicates that the device can be used again. while we are at it
simplify the 3270 irq handling and remove unnecessary code.
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
Diffstat (limited to 'drivers/s390/char/tty3270.c')
| -rw-r--r-- | drivers/s390/char/tty3270.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/s390/char/tty3270.c b/drivers/s390/char/tty3270.c index 54ea5a01e30d..d6da18612ba8 100644 --- a/drivers/s390/char/tty3270.c +++ b/drivers/s390/char/tty3270.c @@ -645,7 +645,7 @@ tty3270_deactivate(struct raw3270_view *view) del_timer(&tp->timer); } -static int +static void tty3270_irq(struct tty3270 *tp, struct raw3270_request *rq, struct irb *irb) { /* Handle ATTN. Schedule tasklet to read aid. */ @@ -667,7 +667,6 @@ tty3270_irq(struct tty3270 *tp, struct raw3270_request *rq, struct irb *irb) tp->update_flags = TTY_UPDATE_ALL; tty3270_set_timer(tp, 1); } - return RAW3270_IO_DONE; } /* |