diff options
| author | Paul Cercueil <paul@crapouillou.net> | 2019-11-16 14:56:19 +0100 |
|---|---|---|
| committer | Sebastian Reichel <sre@kernel.org> | 2019-12-19 01:07:53 +0100 |
| commit | 86b9182df8bb12610d4d6feac45a69f3ed57bfd2 (patch) | |
| tree | 38cff080e190c68500cf55a9816a42267ed08abf /drivers/power/supply/ingenic-battery.c | |
| parent | dd04defd11b78a73b302587575bbcda1019925d8 (diff) | |
| download | lwn-86b9182df8bb12610d4d6feac45a69f3ed57bfd2.tar.gz lwn-86b9182df8bb12610d4d6feac45a69f3ed57bfd2.zip | |
power/supply: ingenic-battery: Don't change scale if there's only one
The ADC in the JZ4740 can work either in high-precision mode with a 2.5V
range, or in low-precision mode with a 7.5V range. The code in place in
this driver will select the proper scale according to the maximum
voltage of the battery.
The JZ4770 however only has one mode, with a 6.6V range. If only one
scale is available, there's no need to change it (and nothing to change
it to), and trying to do so will fail with -EINVAL.
Fixes: fb24ccfbe1e0 ("power: supply: add Ingenic JZ47xx battery driver.")
Signed-off-by: Paul Cercueil <paul@crapouillou.net>
Acked-by: Artur Rojek <contact@artur-rojek.eu>
Cc: stable@vger.kernel.org
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Diffstat (limited to 'drivers/power/supply/ingenic-battery.c')
| -rw-r--r-- | drivers/power/supply/ingenic-battery.c | 15 |
1 files changed, 11 insertions, 4 deletions
diff --git a/drivers/power/supply/ingenic-battery.c b/drivers/power/supply/ingenic-battery.c index 35816d4b3012..2748715c4c75 100644 --- a/drivers/power/supply/ingenic-battery.c +++ b/drivers/power/supply/ingenic-battery.c @@ -100,10 +100,17 @@ static int ingenic_battery_set_scale(struct ingenic_battery *bat) return -EINVAL; } - return iio_write_channel_attribute(bat->channel, - scale_raw[best_idx], - scale_raw[best_idx + 1], - IIO_CHAN_INFO_SCALE); + /* Only set scale if there is more than one (fractional) entry */ + if (scale_len > 2) { + ret = iio_write_channel_attribute(bat->channel, + scale_raw[best_idx], + scale_raw[best_idx + 1], + IIO_CHAN_INFO_SCALE); + if (ret) + return ret; + } + + return 0; } static enum power_supply_property ingenic_battery_properties[] = { |