diff options
| author | Jiasheng Jiang <jiasheng@iscas.ac.cn> | 2022-05-26 17:03:45 +0800 |
|---|---|---|
| committer | Hans de Goede <hdegoede@redhat.com> | 2022-06-10 21:59:08 +0200 |
| commit | 011881b80ebe773914b59905bce0f5e0ef93e7ba (patch) | |
| tree | e2ec0eb7af6f698593a7d2aa679538b02ee9d0b3 /drivers/platform | |
| parent | 552f3b801de6eb062b225a76e140995483a0609c (diff) | |
| download | lwn-011881b80ebe773914b59905bce0f5e0ef93e7ba.tar.gz lwn-011881b80ebe773914b59905bce0f5e0ef93e7ba.zip | |
platform/x86: barco-p50-gpio: Add check for platform_driver_register
As platform_driver_register() could fail, it should be better
to deal with the return value in order to maintain the code
consisitency.
Fixes: 86af1d02d458 ("platform/x86: Support for EC-connected GPIOs for identify LED/button on Barco P50 board")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Acked-by: Peter Korsgaard <peter.korsgaard@barco.com>
Link: https://lore.kernel.org/r/20220526090345.1444172-1-jiasheng@iscas.ac.cn
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Diffstat (limited to 'drivers/platform')
| -rw-r--r-- | drivers/platform/x86/barco-p50-gpio.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/platform/x86/barco-p50-gpio.c b/drivers/platform/x86/barco-p50-gpio.c index 05534287bc26..8dd672339485 100644 --- a/drivers/platform/x86/barco-p50-gpio.c +++ b/drivers/platform/x86/barco-p50-gpio.c @@ -405,11 +405,14 @@ MODULE_DEVICE_TABLE(dmi, dmi_ids); static int __init p50_module_init(void) { struct resource res = DEFINE_RES_IO(P50_GPIO_IO_PORT_BASE, P50_PORT_CMD + 1); + int ret; if (!dmi_first_match(dmi_ids)) return -ENODEV; - platform_driver_register(&p50_gpio_driver); + ret = platform_driver_register(&p50_gpio_driver); + if (ret) + return ret; gpio_pdev = platform_device_register_simple(DRIVER_NAME, PLATFORM_DEVID_NONE, &res, 1); if (IS_ERR(gpio_pdev)) { |