diff options
| author | SungHwan Jung <onenowy@gmail.com> | 2023-11-24 18:41:20 +0900 |
|---|---|---|
| committer | Hans de Goede <hdegoede@redhat.com> | 2023-12-02 12:27:24 +0100 |
| commit | c0ff2c397e84795816816ae8a32fd1104156d0f6 (patch) | |
| tree | 6df43f2d598cab8c27863a20e037367e3895b918 /drivers/platform/x86/Kconfig | |
| parent | 6bb5153dfbaf88fa4b40ef50b706d2fb186ed92e (diff) | |
| download | lwn-c0ff2c397e84795816816ae8a32fd1104156d0f6.tar.gz lwn-c0ff2c397e84795816816ae8a32fd1104156d0f6.zip | |
platform/x86: acer-wmi: Depend on ACPI_VIDEO instead of selecting it
"select ACPI_VIDEO" cause recursive dependency when "depends on HWMON"
is added:
drivers/hwmon/Kconfig:6:error: recursive dependency detected!
drivers/hwmon/Kconfig:6: symbol HWMON is selected by EEEPC_LAPTOP
drivers/platform/x86/Kconfig:326: symbol EEEPC_LAPTOP depends on ACPI_VIDEO
drivers/acpi/Kconfig:208: symbol ACPI_VIDEO is selected by ACER_WMI
drivers/platform/x86/Kconfig:173: symbol ACER_WMI depends on HWMON
Replace the select with depends on to avoid this problem when the next
patch in this series adds "depends on HWMON".
There is a stub defined for the used acpi_video_get_backlight_type()
function when ACPI_VIDEO is not set, so use:
depends on ACPI_VIDEO || ACPI_VIDEO = n
Signed-off-by: SungHwan Jung <onenowy@gmail.com>
Link: https://lore.kernel.org/r/20231124094122.100707-4-onenowy@gmail.com
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Diffstat (limited to 'drivers/platform/x86/Kconfig')
| -rw-r--r-- | drivers/platform/x86/Kconfig | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig index dbde7e018dc1..14059335f19d 100644 --- a/drivers/platform/x86/Kconfig +++ b/drivers/platform/x86/Kconfig @@ -177,7 +177,7 @@ config ACER_WMI depends on INPUT depends on RFKILL || RFKILL = n depends on ACPI_WMI - select ACPI_VIDEO + depends on ACPI_VIDEO || ACPI_VIDEO = n select INPUT_SPARSEKMAP select LEDS_CLASS select NEW_LEDS |