diff options
| author | Yuan Can <yuancan@huawei.com> | 2022-09-24 07:02:58 +0000 |
|---|---|---|
| committer | Vinod Koul <vkoul@kernel.org> | 2022-09-24 13:03:49 +0530 |
| commit | 413e048a2e51bcc96667c711785b40cf742fb366 (patch) | |
| tree | 1b895b5743c4937f1536e19961203b3f06db5131 /drivers/phy | |
| parent | 4c0255e7957d5a536c6da7ba08cbb46540fb5d42 (diff) | |
| download | lwn-413e048a2e51bcc96667c711785b40cf742fb366.tar.gz lwn-413e048a2e51bcc96667c711785b40cf742fb366.zip | |
phy: qcom-qmp-pcie-msm8996: Use dev_err_probe() to simplify code
In the probe path, dev_err() can be replaced with dev_err_probe()
which will check if error code is -EPROBE_DEFER and prints the
error name. It also sets the defer probe reason which can be
checked later through debugfs.
Signed-off-by: Yuan Can <yuancan@huawei.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Reviewed-by: Andrew Halaney <ahalaney@redhat.com>
Link: https://lore.kernel.org/r/20220924070300.25080-3-yuancan@huawei.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'drivers/phy')
| -rw-r--r-- | drivers/phy/qualcomm/phy-qcom-qmp-pcie-msm8996.c | 9 |
1 files changed, 3 insertions, 6 deletions
diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-pcie-msm8996.c b/drivers/phy/qualcomm/phy-qcom-qmp-pcie-msm8996.c index 0f8e739936ab..461f0b5d464a 100644 --- a/drivers/phy/qualcomm/phy-qcom-qmp-pcie-msm8996.c +++ b/drivers/phy/qualcomm/phy-qcom-qmp-pcie-msm8996.c @@ -874,12 +874,9 @@ static int qmp_pcie_msm8996_probe(struct platform_device *pdev) return ret; ret = qmp_pcie_msm8996_vreg_init(dev, cfg); - if (ret) { - if (ret != -EPROBE_DEFER) - dev_err(dev, "failed to get regulator supplies: %d\n", - ret); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, + "failed to get regulator supplies\n"); num = of_get_available_child_count(dev->of_node); /* do we have a rogue child node ? */ |